Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Techdebt: Update TF tests #6661

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

bblommers
Copy link
Collaborator

@bblommers bblommers commented Aug 14, 2023

Updates TF tests to hashicorp/terraform-provider-aws@96ac19e

New methods:
Autoscaling:

  • delete_warm_pool()
  • describe_warm_pool()
  • put_warm_pool()

MQ:

  • list_tags()

ServiceDiscovery:

  • update_private_dns_namespace
  • update_public_dns_namespace

Miscellaneous improvements:

ACM-PCA: create_certificate_authority() now supports the KeyStorageSecurityStandard-parameter
Batch: create_job_definition() now returns more default fields in the containerProperties field
CognitoIDP: UserPools now return the AccountRecoverySetting-field by default
TimestreamWrite: create_table() now supports the Schema-attribute

The AccountRecoverySetting-field was introduced in #4469, as part of a forgot_password overhaul.
Two changes have occured since:

  • The field is now returned when creating a default UserPool
  • Email is now the recovery mechanism with prio 1 (verified on 20 Aug 2023 against us-east-1)

@bblommers bblommers added this to the 4.1.15 milestone Aug 14, 2023
@bblommers bblommers force-pushed the techdebt/update-tf-tests branch 3 times, most recently from d1b1d04 to 2c676a8 Compare August 19, 2023 21:59
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #6661 (2c676a8) into master (c072bac) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is 99.00%.

@@           Coverage Diff            @@
##           master    #6661    +/-   ##
========================================
  Coverage   96.18%   96.19%            
========================================
  Files         806      806            
  Lines       79049    79200   +151     
========================================
+ Hits        76037    76186   +149     
- Misses       3012     3014     +2     
Flag Coverage Δ
servertests 36.85% <20.79%> (+0.01%) ⬆️
unittests 96.13% <99.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
moto/awslambda/models.py 94.31% <ø> (ø)
moto/cloudformation/responses.py 96.76% <ø> (ø)
moto/ec2/responses/nat_gateways.py 100.00% <ø> (ø)
moto/elbv2/models.py 92.70% <ø> (ø)
moto/timestreamwrite/models.py 99.03% <66.66%> (-0.97%) ⬇️
moto/acmpca/models.py 95.55% <100.00%> (+0.03%) ⬆️
moto/acmpca/responses.py 93.33% <100.00%> (+0.07%) ⬆️
moto/autoscaling/models.py 97.09% <100.00%> (+0.08%) ⬆️
moto/autoscaling/responses.py 98.81% <100.00%> (+0.08%) ⬆️
moto/batch/models.py 90.85% <100.00%> (+0.04%) ⬆️
... and 8 more

... and 6 files with indirect coverage changes

@bblommers bblommers force-pushed the techdebt/update-tf-tests branch from 2c676a8 to cdcfae5 Compare August 20, 2023 21:14
@bblommers bblommers force-pushed the techdebt/update-tf-tests branch from cdcfae5 to 6e85dd2 Compare August 21, 2023 18:06
@bblommers bblommers marked this pull request as ready for review August 21, 2023 20:33
@bblommers bblommers merged commit bc29ae2 into getmoto:master Aug 21, 2023
@bblommers bblommers deleted the techdebt/update-tf-tests branch August 21, 2023 20:33
@github-actions
Copy link
Contributor

This is now part of moto >= 4.1.15.dev103

toshyak pushed a commit to toshyak/moto that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant